Add repo revew to tephi #164
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Nov 4, 2024
Merged
|
I'm happy for this to be merged in now, and then track ignores in #155 |
This was referenced Nov 4, 2024
trexfeathers
requested changes
Nov 14, 2024
| rev: 2024.08.19 | ||
| hooks: | ||
| - id: sp-repo-review | ||
| additional_dependencies: ["repo-review[cli]"] |
There was a problem hiding this comment.
Suggested change
| additional_dependencies: ["repo-review[cli]"] | |
| additional_dependencies: ["repo-review[cli]"] | |
| args: ["--show=errskip"] | |
Aligns with the template (which itself is based on other SciTools repos).
Comment on lines
+15
to
+36
| [tool.repo-review] | ||
| # These are a list of the currently failing tests: | ||
| ignore = [ | ||
| "PY005", # Has tests folder -- | ||
| "PP003", # Does not list wheel as a build-dep -- | ||
| "PP301", # Has pytest in project -- | ||
| "PP304", # Sets the log level in pytest s | ||
| "PP305", # Specifies xfail_strict s | ||
| "PP306", # Specifies strict config s | ||
| "PP307", # Specifies strict markers s | ||
| "PP309", # Filter warnings specified s | ||
| "GH212", # Require GHA update grouping -- | ||
| "PC110", # Uses black or ruff-format -- | ||
| "PC140", # Uses a type checker -- | ||
| "PC160", # Uses a spell checker -- | ||
| "PC170", # Uses PyGrep hooks (only needed if rST present) -- | ||
| "PC180", # Uses a markdown formatter -- | ||
| "PC190", # Uses Ruff -- | ||
| "PC901", # Custom pre-commit CI message -- | ||
| "MY100", # Uses MyPy (pyproject config) -- | ||
| "RF001", # Has Ruff config -- | ||
| ] |
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Pull Request
Starts #155