Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to skip unsupported files #343

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yet-another-aligator
Copy link

@yet-another-aligator yet-another-aligator commented Nov 2, 2023

This PR provides a new Builder::skip_unsupported_file_types(&mut self, skip: bool) method, for allowing to silently skip unsupported files, instead of returning with an error.

For the moment, this feature applies to the case of UNIX named sockets only.

@yet-another-aligator yet-another-aligator force-pushed the skip_unsupported_special branch 2 times, most recently from 2bcd07e to fa458aa Compare November 2, 2023 17:38
@yet-another-aligator yet-another-aligator marked this pull request as draft November 20, 2023 14:59
@yet-another-aligator yet-another-aligator marked this pull request as ready for review November 20, 2023 15:14
Copy link
Collaborator

@cgwalters cgwalters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we really just need this as a variant of append_dir_all() right? I'd probably have it take a closure which filters the entries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants