-
-
Notifications
You must be signed in to change notification settings - Fork 3.9k
Make SubCameraView
into a new primitive shape
#19302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
It looks like your PR has been selected for a highlight in the next release blog post, but you didn't provide a release note. Please review the instructions for writing release notes, then expand or revise the content in the release notes directory to showcase your changes. |
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
1 similar comment
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
1 similar comment
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Your PR caused a change in the graphical output of an example or rendering test. This might be intentional, but it could also mean that something broke! If it's expected, please add the M-Deliberate-Rendering-Change label. If this change seems unrelated to your PR, you can consider updating your PR to target the latest main branch, either by rebasing or merging main into it. |
Step 2 of the camera restructure!
Motivation: In the proposal, I've stolen the
SubView
name to represent a component that requests a viewport proportional to the size of the render target managed by a compositor. Funnily enough, that means keeping the exact type definition ofCameraSubView
but using it for a different purpose, which I feel warrants splitting out the idea of a proportional "sub-rectangle" into its own type.SubCameraView
toSubRect
and move tobevy_render::primitives
(bikeshedding badly needed for the name)Self
, with the idea being that most of the "frontend" components in the proposal are immutable.Camera::sub_view
toCamera::crop
and edited docs. I think this name better reflects its purpose of limiting the extents the camera actually renders to, and avoids conflicting with future alternate usage of "SubView"Testing
TODO:
fix(omitted from this pr, it's non-trivial I think)SubRect::inset_by