Skip to content

Fix spawn tracking for spawn commands #19351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix spawn tracking for spawn commands #19351

wants to merge 2 commits into from
+92 −6

Conversation

SpecificProtagonist
Copy link
Contributor

@SpecificProtagonist SpecificProtagonist commented May 24, 2025 •
edited
Loading

Objective

See also https://discord.com/channels/691052431525675048/1374187654425481266/1375553989185372292.

Solution

Set spawn info in Commands::spawn_empty.
Also added a benchmark for Commands::spawn.

Testing

See added test.

@SpecificProtagonist SpecificProtagonist added C-Bug An unexpected or incorrect behavior A-ECS Entities, components, systems, and events S-Needs-Review Needs reviewer attention (from anyone!) to move forward labels May 24, 2025
@alice-i-cecile alice-i-cecile added this to the 0.16.1 milestone May 24, 2025
@SpecificProtagonist
Copy link
Contributor Author

This PR impacts the perf of Commands::spawn_empty – the spawn_commands benchmark is about 10% slower – as it now has to queue a command. The performance of Commands::spawn is unaffected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alice-i-cecile alice-i-cecile alice-i-cecile approved these changes

Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Bug An unexpected or incorrect behavior S-Needs-Review Needs reviewer attention (from anyone!) to move forward
Projects
None yet
Milestone
0.16.1
Development

Successfully merging this pull request may close these issues.
2 participants
@SpecificProtagonist @alice-i-cecile