Skip to content

Use SlotMaps to store systems and system sets in Schedules #19352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Use SlotMaps to store systems and system sets in Schedules #19352

wants to merge 2 commits into from

Conversation

ItsDoot
Copy link
Contributor

@ItsDoot ItsDoot commented May 24, 2025

Objective

Solution

Makes the necessary internal data structure changes in order to allow system removal to be added in a future PR: Vecs storing systems and system sets in ScheduleGraph have been replaced with SlotMaps.

See the included migration guide for the required changes.

Testing

Internal changes only and no new features should mean no new tests are requried.

@ItsDoot ItsDoot marked this pull request as draft May 24, 2025 03:05
@ItsDoot ItsDoot force-pushed the schedule/slotmap branch from 1f9ed64 to a91e7de Compare May 24, 2025 03:13
@ItsDoot ItsDoot added A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes labels May 24, 2025
@ItsDoot ItsDoot force-pushed the schedule/slotmap branch from a91e7de to bfed18a Compare May 24, 2025 03:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
A-ECS Entities, components, systems, and events C-Code-Quality A section of code that is hard to understand or change D-Modest A "normal" level of difficulty; suitable for simple features or challenging fixes M-Needs-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ItsDoot