SpatialListener now requires a Transform #19357
Open
+5
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mnmaita
added
A-ECS
hukasu
reviewed
May 24, 2025
| /// Only one entity with a `SpatialListener` should be present at any given time. | ||
| #[derive(Component, Clone, Debug, Reflect)] | ||
| #[require(bevy_transform::components::Transform)] |
There was a problem hiding this comment.
does Transform exist already on this file to have to use the full path?
There was a problem hiding this comment.
no i had to import it
There was a problem hiding this comment.
then use just Transform instead of full path
hukasu
reviewed
May 24, 2025
Comment on lines
+143
to
144
| /// This is accompanied by `Transform` and `GlobalTransform`. | ||
| /// Only one entity with a `SpatialListener` should be present at any given time. |
There was a problem hiding this comment.
Could update the docs to use doc links (i.e. [``Transform``])
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the
SpatialListenerasks to have aTransformattached. It seemed weird that we didnt just use a require macro, so i went ahead and did thatI also tweaked the system that plays audio to use a
&GlobalTransforminstead of anOption<&GlobalTransform>