Eliminate some unnecessary allocations in AssetPath - #25742
Open
Mysvac wants to merge 1 commit into
Open
Conversation
Mysvac
changed the title
Mysvac
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Eliminate some unnecessary memory allocations in AssetPath's methods (bevy_asset).
AssetPath::parent
Converting
&Pathdirectly toArc<Path>is the fastest approach, requiring only one allocation.But the current implementation is
&Path -> PathBuf -> Arc<Path>, which requires two.The
PathBuf -> Arc<Path>step requires an allocation and a copy; see the standard library implementation for details.AssetPath::is_unapproved
Currently, using PathBuf as a stack is unnecessary. Switching to an integer counter is sufficient.
Solution
See
FileChangedfor details — the change is minimal.Testing
None