Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update misleading documentation about importing compressed WAV files #10729

Merged
merged 6 commits into from
Mar 6, 2025

Conversation

GlitchedCode922
Copy link
Contributor

Fixes #10626

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to just edit the bullet point instead of adding a note. Change it to something like "WAV files must be imported raw, but Godot can apply light compression on them (IMA-ADPCM or QOA)" or something like that, there's probably a better way to phrase it.

@skyace65 skyace65 added enhancement area:manual Issues and PRs related to the Manual/Tutorials section of the documentation labels Mar 2, 2025
@GlitchedCode922 GlitchedCode922 requested a review from skyace65 March 3, 2025 08:22
@skyace65
Copy link
Contributor

skyace65 commented Mar 5, 2025

Haven't forgotten this, trying to figure out a way to improve the wording.

Copy link
Contributor Author

@GlitchedCode922 GlitchedCode922 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this better?

Copy link
Contributor

@skyace65 skyace65 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just going to adjust the line wrapping here

@skyace65 skyace65 merged commit 996095e into godotengine:master Mar 6, 2025
2 checks passed
@skyace65
Copy link
Contributor

skyace65 commented Mar 6, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:manual Issues and PRs related to the Manual/Tutorials section of the documentation enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compressed WAVs are not supported, contrary to the documentation
2 participants