Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken model.vis repr #2496

Merged
merged 1 commit into from
Mar 13, 2025
Merged

Conversation

jjyyxx
Copy link
Contributor

@jjyyxx jjyyxx commented Mar 11, 2025

Closes #2488

>>> model.vis
<MjVisual
  global_: <Global
    azimuth: 90.0
    realtime: 1.0
  >
  quality: <Quality
    numquads: 4
    shadowsize: 4096
  >
  headlight: <Headlight
    active: 1
    specular: array([0.5, 0.5, 0.5], dtype=float32)
  >
  map: <Map
    actuatortendon: 2.0
    znear: 0.009999999776482582
  >
  scale: <Scale
    actuatorlength: 0.699999988079071
    slidercrank: 0.20000000298023224
  >
  rgba: <Rgba
    actuator: array([0.2 , 0.25, 0.2 , 1.  ], dtype=float32)
    slidercrank: array([0.5, 0.3, 0.8, 1. ], dtype=float32)
  >
>

@jjyyxx jjyyxx mentioned this pull request Mar 11, 2025
2 tasks
@nimrod-gileadi nimrod-gileadi self-assigned this Mar 13, 2025
@copybara-service copybara-service bot merged commit a7a8a68 into google-deepmind:main Mar 13, 2025
14 checks passed
@yuvaltassa
Copy link
Collaborator

@jjyyxx, please note slight differences between your original PR and a7a8a68:

  1. Added a basic test.
  2. Correct indentation.

(credit @nimrod-gileadi )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken repr for MjModel.vis
3 participants