Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move output format information to the first queue channel of last/mafconvert #7428

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

charles-plessy
Copy link
Contributor

@charles-plessy charles-plessy commented Feb 4, 2025

This allows pipelines to use the last/mafconvert module to convert the same alignment file to different formats in parallel through a channel combine operation.

In addition I made a minor fix to the stubs that ensured that output files are the same as in the real computation.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

charles-plessy and others added 2 commits February 4, 2025 14:20
This allows pipelines to use the `last/mafconvert` module to convert the
same alignment file to different formats in parallel through a channel
combine operation.

In addition I made a minor fix to the stubs that ensured that output
files are the same as in the real computation.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants