-
Notifications
You must be signed in to change notification settings - Fork 752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
simplify assertion for stable files in a folder #7462
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is awesome!
@@ -60,45 +60,48 @@ | |||
"library-files.txt:md5,8a9817d2de8465eb436aa3aa8696a717", | |||
"genome.fasta:md5,6e9fe4042a72f2345f644f239272b7e6", | |||
"seqid2taxid.map:md5,fe738f2333d57dde0db32239c04a93b8", | |||
"taxDB:md5,37ea954363803b13c2c9f6ae36fc81c7" | |||
"taxDB:md5,f9969245ac82fa42682289f5b0b6c67a" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so I'm concerned that taxDB
is actually not stable
], | ||
[ | ||
"database-build.log", | ||
"database.report.tsv", | ||
"library", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I rescued library as a folder name
"names.dmp", | ||
"nodes.dmp", | ||
"taxdump.tar.gz", | ||
"taxonomy", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and taxonomy
Co-authored-by: Matthias Hörtenhuber <[email protected]>
Please let's not merge this, I'll try to fix this properly within nft-utils. My endgoal is something like:
|
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda