Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simplify assertion for stable files in a folder #7462

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

maxulysse
Copy link
Member

PR checklist

Closes #XXX

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

Copy link
Contributor

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome!

@@ -60,45 +60,48 @@
"library-files.txt:md5,8a9817d2de8465eb436aa3aa8696a717",
"genome.fasta:md5,6e9fe4042a72f2345f644f239272b7e6",
"seqid2taxid.map:md5,fe738f2333d57dde0db32239c04a93b8",
"taxDB:md5,37ea954363803b13c2c9f6ae36fc81c7"
"taxDB:md5,f9969245ac82fa42682289f5b0b6c67a"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so I'm concerned that taxDB is actually not stable

],
[
"database-build.log",
"database.report.tsv",
"library",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I rescued library as a folder name

"names.dmp",
"nodes.dmp",
"taxdump.tar.gz",
"taxonomy",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and taxonomy

@maxulysse maxulysse marked this pull request as draft February 11, 2025 16:04
@maxulysse
Copy link
Member Author

Please let's not merge this, I'll try to fix this properly within nft-utils.

My endgoal is something like:

    then {
      def unstableNames = ["stable_name_infolder.txt", "stable_name_in_subfolder.txt"]
      def stableFiles = getAllFilesFromChannel(process.out.folder[0][1], ignore: unstableNames)
      def stableNames = getAllFilesFromChannel(process.out.folder[0][1], includeDir: true, include: unstableNames)

      assertAll(
        { assert process.success },
        { assert snapshot(
            stableFiles,
            stableNames
          ).match()
        }
      )
    }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants