Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Swap graphtyper/genotype to nf-test #7484

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Swap graphtyper/genotype to nf-test #7484

wants to merge 1 commit into from
+285 −125

Conversation

SPPearce
Copy link
Contributor

No description provided.

@SPPearce SPPearce requested a review from a team as a code owner February 14, 2025 16:02
itrujnara
itrujnara reviewed Feb 18, 2025
View reviewed changes
Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work as always, I've left you some bits of me being picky to think about. Feel free to argue.

modules/nf-core/graphtyper/genotype/main.nf
@@ -23,7 +23,6 @@ process GRAPHTYPER_GENOTYPE {

script:
def args = task.ext.args ?: ''
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know it's out of PR scope but can we get Harshil alignment on this section?

modules/nf-core/graphtyper/genotype/tests/main.nf.test

}

test("single - region_file - stub") {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it make sense to make a stud test for the other option? I know the outputs will be the same but technically the inputs are different

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmm, the stub itself isn't really actually mimicking the module, as I don't understand what it is doing in terms of output.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Me neither so I guess it can stay this way

itrujnara
itrujnara approved these changes Feb 19, 2025
View reviewed changes
Copy link
Contributor

@itrujnara itrujnara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the reply, good to go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itrujnara itrujnara itrujnara approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SPPearce @itrujnara