Skip to content

Conversation

saikishor
Copy link
Member

This PR consists of changes to cleanup the saturation boolean of the PID toolbox

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 76.00000% with 36 lines in your changes missing coverage. Please review.

Project coverage is 76.85%. Comparing base (04c1a2e) to head (6042d15).

Files with missing lines Patch % Lines
control_toolbox/src/pid_ros.cpp 67.14% 22 Missing and 1 partial ⚠️
control_toolbox/src/pid.cpp 36.84% 10 Missing and 2 partials ⚠️
control_toolbox/include/control_toolbox/pid.hpp 85.71% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           ros2-master     #390      +/-   ##
===============================================
- Coverage        77.03%   76.85%   -0.19%     
===============================================
  Files               30       30              
  Lines             1707     1741      +34     
  Branches           103      107       +4     
===============================================
+ Hits              1315     1338      +23     
- Misses             336      344       +8     
- Partials            56       59       +3     
Flag Coverage Δ
unittests 76.85% <76.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ontrol_toolbox/include/control_toolbox/pid_ros.hpp 100.00% <ø> (ø)
control_toolbox/test/pid_ros_parameters_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/test/pid_ros_publisher_tests.cpp 95.00% <ø> (ø)
control_toolbox/test/pid_tests.cpp 100.00% <100.00%> (ø)
control_toolbox/include/control_toolbox/pid.hpp 78.26% <85.71%> (-4.10%) ⬇️
control_toolbox/src/pid.cpp 68.38% <36.84%> (-2.86%) ⬇️
control_toolbox/src/pid_ros.cpp 66.43% <67.14%> (+0.50%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@saikishor saikishor marked this pull request as ready for review June 10, 2025 19:53
Copy link
Contributor

@christophfroehlich christophfroehlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the cleanup, LGTM

@christophfroehlich christophfroehlich merged commit f130521 into ros2-master Jun 10, 2025
18 of 22 checks passed
@christophfroehlich christophfroehlich deleted the cleanup/saturation/antiwindup branch June 10, 2025 21:20
@saikishor saikishor added the backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 jazzy. label Jun 10, 2025
mergify bot pushed a commit that referenced this pull request Jun 10, 2025
christophfroehlich pushed a commit that referenced this pull request Jun 11, 2025
) (#393)

(cherry picked from commit f130521)

Co-authored-by: Sai Kishor Kothakota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-jazzy This label should be used by maintainers only! Label triggers PR backport to ROS 2 jazzy.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants