-
Notifications
You must be signed in to change notification settings - Fork 111
Cleanup saturation parameter in the methods and constructors #390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup saturation parameter in the methods and constructors #390
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## ros2-master #390 +/- ##
===============================================
- Coverage 77.03% 76.85% -0.19%
===============================================
Files 30 30
Lines 1707 1741 +34
Branches 103 107 +4
===============================================
+ Hits 1315 1338 +23
- Misses 336 344 +8
- Partials 56 59 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Co-authored-by: Christoph Fröhlich <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the cleanup, LGTM
) (cherry picked from commit f130521)
) (#393) (cherry picked from commit f130521) Co-authored-by: Sai Kishor Kothakota <[email protected]>
This PR consists of changes to cleanup the saturation boolean of the PID toolbox