Skip to content

Add some logging for --unload-on-kill keyboard interrupt #2097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

saikishor
Copy link
Member

Add some meaningful information for the --unload-on-kill options.

This might be interesting to have to introspect #2063, I'm not able to reproduce this locally even after 300+ runs

Copy link

codecov bot commented Mar 10, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 89.51%. Comparing base (bfbedd2) to head (51ea19c).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
controller_manager/controller_manager/spawner.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2097      +/-   ##
==========================================
- Coverage   89.59%   89.51%   -0.08%     
==========================================
  Files         139      139              
  Lines       15222    15227       +5     
  Branches     1290     1290              
==========================================
- Hits        13638    13631       -7     
- Misses       1096     1105       +9     
- Partials      488      491       +3     
Flag Coverage Δ
unittests 89.51% <66.66%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
controller_manager/controller_manager/spawner.py 74.45% <66.66%> (-0.37%) ⬇️

... and 3 files with indirect coverage changes

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@christophfroehlich christophfroehlich merged commit cc3491c into ros-controls:master Mar 10, 2025
26 checks passed
@christophfroehlich christophfroehlich deleted the unload_on_kill/better_logs branch March 10, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants