fixed on_set_chained_mode implementations to avoid cpplint warnings #1564
+4
−20
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
bijoua29,
bmagyar,
destogl,
homalozoa,
LukasMacha97,
mcbed and
mhubii
bmagyar
reviewed
Mar 2, 2025
| @@ -689,8 +689,9 @@ controller_interface::CallbackReturn DiffDriveController::configure_side( | |||
|
|
|||
| bool DiffDriveController::on_set_chained_mode(bool chained_mode) | |||
| { | |||
| // Always accept switch to/from chained mode (without linting type-cast error) | |||
| return true || chained_mode; | |||
| // Fix to adhere to CppLint standards | |||
There was a problem hiding this comment.
A moor reference isn't really adhering to cppkint standards ;)
There was a problem hiding this comment.
You can achieve the same by commenting out the name of the argument. It tricks the parser and also the compiler. We already use that approach in the codebase, just look for "/*" in ros2_control
There was a problem hiding this comment.
No, I don't think so. See #1491 and the linked cpplint issue.
bmagyar
requested changes
Mar 2, 2025
| @@ -689,8 +689,9 @@ controller_interface::CallbackReturn DiffDriveController::configure_side( | |||
|
|
|||
| bool DiffDriveController::on_set_chained_mode(bool chained_mode) | |||
| { | |||
| // Always accept switch to/from chained mode (without linting type-cast error) | |||
| return true || chained_mode; | |||
| // Fix to adhere to CppLint standards | |||
There was a problem hiding this comment.
You can achieve the same by commenting out the name of the argument. It tricks the parser and also the compiler. We already use that approach in the codebase, just look for "/*" in ros2_control
Closed
8 tasks
saikishor
approved these changes
May 17, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1564 +/- ##
=======================================
Coverage 85.60% 85.61%
=======================================
Files 123 123
Lines 11873 11860 -13
Branches 1016 1015 -1
=======================================
- Hits 10164 10154 -10
+ Misses 1384 1383 -1
+ Partials 325 323 -2
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
christophfroehlich
added
backport-humble
christophfroehlich
merged commit d8dc4b1
into
ros-controls:master
21 of 26 checks passed
This was referenced May 17, 2025
christophfroehlich
pushed a commit
that referenced
this pull request
May 17, 2025
) (#1688) Co-authored-by: Bhagyesh Agresar <[email protected]>
christophfroehlich
pushed a commit
that referenced
this pull request
May 17, 2025
) (#1687) Co-authored-by: Bhagyesh Agresar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed warnings generated by cpplint/cpplint#131 on some of the controllers that implement the chained mode.