-
Notifications
You must be signed in to change notification settings - Fork 441
Tf prefix helper for omniwheel drive #2073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tf prefix helper for omniwheel drive #2073
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2073 +/- ##
==========================================
- Coverage 84.78% 84.72% -0.06%
==========================================
Files 151 151
Lines 14556 14543 -13
Branches 1265 1266 +1
==========================================
- Hits 12341 12322 -19
- Misses 1761 1763 +2
- Partials 454 458 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
|
This pull request is in conflict. Could you fix it @kuralme? |
christophfroehlich
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
|
Not exactly right place to ask but since this is open... I am confused about the steering controller part in your comment. There are no tf prefix related params/codes in steering_controllers_library, shall i create new params in the yaml, similar codes and tests? |
|
you can also comment in closed PRs ;) Yes, please just add it if it is not available there (no need for the backward compatibility stuff obviously). |
Juliaj
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
5cbd8c4
into
ros-controls:master
Used tf frame prefix helper similar to the diff drive controller. TF enable-flag tests removed.
Related PR