Feat/18998 #19018
Merged
Feat/18998 #19018
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Jenkins BuildsClick to see older builds (51)
|
Khushboo-dev-cpp
force-pushed
the
feat/18998
branch
from
e03bef6 to
d7b1758
Compare
Khushboo-dev-cpp
requested review from
a team,
alexjba,
caybro,
micieslak and
noeliaSD
as code owners
Khushboo-dev-cpp
requested review from
saledjenic
and removed request for
a team
Khushboo-dev-cpp
force-pushed
the
feat/18998
branch
from
d7b1758 to
590af31
Compare
jrainville
approved these changes
Oct 23, 2025
Member
jrainville
left a comment
jrainville
left a comment
There was a problem hiding this comment.
Good job. I just had nitpicks
ui/app/mainui/AppMain.qml
Outdated
|
|
||
| function openLinkInBrowser(link: string) { | ||
| if (appMain.rootStore.openLinksInStatus && d.isBrowserEnabled) { | ||
| globalConns.onAppSectionBySectionTypeChanged(Constants.appSection.browser) |
Member
There was a problem hiding this comment.
Why do you need to call this? Shouldn't changeAppSectionBySectionId call the needed signal that would be caught?
Contributor
Author
There was a problem hiding this comment.
:( it does not! I expected it too, but it doesn't so I've left as I did not want to make any further changes in this PR.
Khushboo-dev-cpp
force-pushed
the
feat/18998
branch
2 times, most recently
from
c9fcdcc to
cfb9450
Compare
alaibe
approved these changes
Nov 5, 2025
anymore in our workflow
designs to keep consitent behaviour in both privacy mode and without
trusted sites in the Privacy and Security view
Khushboo-dev-cpp
force-pushed
the
feat/18998
branch
from
cfb9450 to
1c4bbb1
Compare
links to new api based on the new behaviour
Khushboo-dev-cpp
force-pushed
the
feat/18998
branch
from
1c4bbb1 to
39af457
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#18998
What does the PR do
Implements the new designs for handling external links making them constant in both Privacy mode and without ..
https://www.figma.com/design/idUoxN7OIW2Jpp3PMJ1Rl8/Settings----Desktop-Legacy?node-id=27093-584044&m=dev
Affected areas
Externals link all over the app
Privacy and Security settings
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Screen.Recording.2025-10-16.at.11.36.57.mov
Impact on end user
How to test
Risk