Skip to content

Conversation

@faisal
Copy link
Contributor

@faisal faisal commented Mar 28, 2025

Per https://endoflife.date/ruby, Ruby 3.1 is EOL. This PR prepares for when we want to drop support.

Note: this PR changes the JRuby CI tests from 9.4 (Ruby 3.1) to 10 (Ruby 3.4), which Rubycritic does not yet fully support.

  • rubycritic.gemspec: update minimum Ruby version to 3.2, and improve support for JRuby.
  • .rubocop.yml: update target Ruby version to 3.2
  • CI: drop Ruby 3.1, change jruby from 9.4 (Ruby 3.1) to 10 (Ruby 3.4), and set continue-on-error for steps running on all experimental rubies (jruby and ruby-head)

Check list:

@faisal
Copy link
Contributor Author

faisal commented Mar 28, 2025

The JRuby failures make me think that in practice this PR needs to land on top of #508.

@faisal faisal force-pushed the ruby_3_1_eol branch 2 times, most recently from e290fa9 to 1a16b19 Compare April 1, 2025 11:58
@faisal faisal marked this pull request as draft April 1, 2025 12:02
@faisal faisal force-pushed the ruby_3_1_eol branch 2 times, most recently from e5a99e2 to 150583b Compare April 9, 2025 07:31
@faisal faisal marked this pull request as ready for review April 9, 2025 07:48
@faisal faisal marked this pull request as draft June 28, 2025 21:46
@faisal
Copy link
Contributor Author

faisal commented Jul 29, 2025

bundle exec rake features and bundle exec rake test now pass for me cleanly on jruby on my local machine.

@faisal faisal changed the title Remove support for Ruby 3.1 Remove support for Ruby 3.1 and aligned JRuby 9.4. Add support for JRuby 10. Jul 29, 2025
@faisal
Copy link
Contributor Author

faisal commented Jul 29, 2025

Note that this includes some of the JRuby support fixes from #508.

@faisal faisal marked this pull request as ready for review July 29, 2025 14:42
@faisal
Copy link
Contributor Author

faisal commented Jul 29, 2025

This could probably use more review than "we finally got CI to pass."

@faisal faisal mentioned this pull request Jul 31, 2025
@faisal faisal marked this pull request as draft July 31, 2025 16:20
@faisal
Copy link
Contributor Author

faisal commented Jul 31, 2025

This patch only differs from the prior attempt in that the CHANGELOG was updated. This failure is the same failure as from two runs ago. I do not see it on my machine. I could use help investigating.

@faisal
Copy link
Contributor Author

faisal commented Aug 19, 2025

I can now intermittently reproduce this failure locally.

@faisal faisal force-pushed the ruby_3_1_eol branch 2 times, most recently from e0748a8 to 68a71fd Compare October 14, 2025 17:58
@faisal faisal marked this pull request as ready for review October 14, 2025 18:02
@faisal
Copy link
Contributor Author

faisal commented Oct 14, 2025

This drops Ruby 3.1 support, which means dropping JRuby 9 support, which means using JRuby 10, on which Rubycritic doesn't quite work yet. Is that an acceptable tradeoff?

@faisal faisal changed the title Remove support for Ruby 3.1 and aligned JRuby 9.4. Add support for JRuby 10. Remove support for Ruby 3.1 and aligned JRuby 9.4 Oct 14, 2025
@JuanVqz
Copy link
Contributor

JuanVqz commented Oct 14, 2025

This drops Ruby 3.1 support, which means dropping JRuby 9 support, which means using JRuby 10, on which Rubycritic doesn't quite work yet. Is that an acceptable tradeoff?

I didn't see this PR before; even though Ruby 3.1 is EOL, IMO, it is fine keeping support on it since we want/need to support as many Ruby versions as we can (as long as it is not torture), If it is hard to make their tests pass we can move it to experimental in CI.

But I would love to know what @etagwerker thinks about it.

@faisal
Copy link
Contributor Author

faisal commented Oct 17, 2025

This drops Ruby 3.1 support, which means dropping JRuby 9 support, which means using JRuby 10, on which Rubycritic doesn't quite work yet. Is that an acceptable tradeoff?

I didn't see this PR before; even though Ruby 3.1 is EOL, IMO, it is fine keeping support on it since we want/need to support as many Ruby versions as we can (as long as it is not torture), If it is hard to make their tests pass we can move it to experimental in CI.

But I would love to know what @etagwerker thinks about it.

I don't have a particular urgency to kill 3.1 support, but am trying to keep this PR current so we have the option when we decide to drop the support.

Also see #482 for additional discussion of when we should be in the habit of doing such things.

…upport for JRuby 10

- rubycritic.gemspec: update minimum Ruby version to 3.2
- .rubocop.yml: update target Ruby version to 3.2
- CI: drop Ruby 3.1 and jruby 9.4 (Ruby 3.1), and convert to testing against jruby 10
- add platform value to the gemspec, and require jar-dependencies version
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants