-
Notifications
You must be signed in to change notification settings - Fork 132
Fix clang tidy ci #2375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clang tidy ci #2375
Conversation
b8443c3
to
9b40ed0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
crypto/bio/bio.c
Outdated
@@ -443,7 +443,7 @@ int BIO_flush(BIO *bio) { | |||
} | |||
|
|||
long BIO_ctrl(BIO *bio, int cmd, long larg, void *parg) { | |||
if (bio == NULL) { | |||
if (bio != NULL) { | |||
return 0; | |||
} | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
warning: Access to field 'method' results in a dereference of a null pointer (loaded from variable 'bio') [clang-analyzer-core.NullDereference]
if (bio->method == NULL || bio->method->ctrl == NULL) {
^
Additional context
crypto/bio/bio.c:598: Passing value via 1st parameter 'bio'
return (int)BIO_ctrl(bio, BIO_CTRL_SET_CLOSE, close_flag, NULL);
^
crypto/bio/bio.c:598: Calling 'BIO_ctrl'
return (int)BIO_ctrl(bio, BIO_CTRL_SET_CLOSE, close_flag, NULL);
^
crypto/bio/bio.c:445: Assuming 'bio' is equal to NULL
if (bio != NULL) {
^
crypto/bio/bio.c:445: Taking false branch
if (bio != NULL) {
^
crypto/bio/bio.c:449: Access to field 'method' results in a dereference of a null pointer (loaded from variable 'bio')
if (bio->method == NULL || bio->method->ctrl == NULL) {
^
a1262f4
to
4109d21
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2375 +/- ##
==========================================
- Coverage 78.81% 78.80% -0.02%
==========================================
Files 621 621
Lines 108417 108417
Branches 15399 15399
==========================================
- Hits 85447 85435 -12
- Misses 22299 22312 +13
+ Partials 671 670 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
40589ff
to
5f5ed93
Compare
@@ -11,6 +11,5 @@ Checks: ' | |||
modernize-*, | |||
performance-*, | |||
portability-*, | |||
readability-* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The "readability-*" lints are very noisy in our code base.
5f5ed93
to
bab60d3
Compare
Issues:
Addresses P229174291
Description of changes:
Fixes usage of clang-tidy-review:
compile_commands.json
Made changes to clang-tidy-review to preserve comments that are very close to lines in the diff
Testing:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and the ISC license.